Skip to content

feat: make new unit outline design default and fix sidebar for Content Experiments [FC-0123]#3034

Open
rpenido wants to merge 2 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4335/update-new-unit-page-design-flag
Open

feat: make new unit outline design default and fix sidebar for Content Experiments [FC-0123]#3034
rpenido wants to merge 2 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4335/update-new-unit-page-design-flag

Conversation

@rpenido
Copy link
Copy Markdown
Contributor

@rpenido rpenido commented Apr 28, 2026 •
edited
Loading

Description

This PR sets the default value of ENABLE_UNIT_PAGE_NEW_DESIGN to true, and fix some issues with the Content Experiments xblock with the new sidebar.

Useful information to include:

  • Which user roles will this change impact?
    "Course Author", "Developer", and "Operator".

Supporting information

Testing instructions

  • Check the docs to enable content experiments
  • Create a Content Experiment block on a unit
  • Open the block and check the sidebar
    • The add button on the sidebar must be disabled

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

Private ref: FAL-4335

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 28, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Apr 28, 2026 •
edited
Loading

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 28, 2026
@rpenido rpenido marked this pull request as ready for review April 28, 2026 19:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.47%. Comparing base (3b4ae21) to head (fe9bfa6).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #3034    +/-   ##
========================================
  Coverage   95.47%   95.47%            
========================================
  Files        1383     1383            
  Lines       32597    32600     +3     
  Branches     7466     7251   -215     
========================================
+ Hits        31121    31124     +3     
- Misses       1407     1420    +13     
+ Partials       69       56    -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido force-pushed the rpenido/fal-4335/update-new-unit-page-design-flag branch 5 times, most recently from f64b37f to 2a3ddec Compare April 28, 2026 22:58
@rpenido rpenido force-pushed the rpenido/fal-4335/update-new-unit-page-design-flag branch from 2a3ddec to 5af5916 Compare April 28, 2026 23:15
@rpenido rpenido requested review from ChrisChV and navinkarkera and removed request for ChrisChV April 29, 2026 01:25
navinkarkera
navinkarkera approved these changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@navinkarkera navinkarkera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good.

👍

  • I tested this: (Verified add button in content experiment block)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Edit: Are we planning to remove the flag and related code in another PR? The issue is about removing it no?

Comment thread src/course-unit/unit-sidebar/UnitSidebarPagesContext.tsx Outdated
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Apr 29, 2026
@ChrisChV ChrisChV changed the title feat: make new unit outline design default and fix sidebar for Content Experiments feat: make new unit outline design default and fix sidebar for Content Experiments [FC-0123] Apr 29, 2026
ChrisChV
ChrisChV approved these changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Check the pending nit to merge this. Thanks!

@rpenido @navinkarkera
fix: fixes from review
fe9bfa6 
Co-authored-by: Navin Karkera <[email protected]>
@rpenido
Copy link
Copy Markdown
Contributor Author

rpenido commented Apr 29, 2026

Edit: Are we planning to remove the flag and related code in another PR? The issue is about removing it no?

@navinkarkera The Legacy Unit sidebar may be needed for Content Experiments. We may want to migrate more things from the Legacy Unit Sidebar to the new sidebar. Also, we are almost out of budget here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisChV ChrisChV ChrisChV approved these changes

+1 more reviewer

@navinkarkera navinkarkera navinkarkera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Status: In Eng Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rpenido @openedx-webhooks @navinkarkera @ChrisChV @mphilbrick211